Skip to content

Do not copy files to build server for a Delete. - #16752

Merged
rolfbjarne merged 4 commits into
dotnet:mainfrom
dellis1972:fastdelete
Nov 17, 2022
Merged

Do not copy files to build server for a Delete.#16752
rolfbjarne merged 4 commits into
dotnet:mainfrom
dellis1972:fastdelete

Conversation

@dellis1972

@dellis1972 dellis1972 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

The Delete task should not need to copy any files to the remote server.
Lets try to set this up by implementing the ShouldCopyToBuildServer method.

This should help reduce build times if it works.

dellis1972
dellis1972 commented Nov 15, 2022
View reviewed changes
Comment thread msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs
@dellis1972
dellis1972 marked this pull request as ready for review November 16, 2022 09:43
@dellis1972
dellis1972 requested a review from mauroa as a code owner November 16, 2022 09:43
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne

rolfbjarne commented Nov 16, 2022

Copy link
Copy Markdown
Member 
     /Users/builder/azdo/_work/3/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs(4,36): error CS0535: 'Delete' does not implement interface member 'ITaskCallback.ShouldCopyToBuildServer(ITaskItem)' [/Users/builder/azdo/_work/3/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/Xamarin.MacDev.Tasks.csproj]
     /Users/builder/azdo/_work/3/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs(4,36): error CS0535: 'Delete' does not implement interface member 'ITaskCallback.ShouldCreateOutputFile(ITaskItem)' [/Users/builder/azdo/_work/3/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/Xamarin.MacDev.Tasks.csproj]
     /Users/builder/azdo/_work/3/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/MsBuildTasks/Delete.cs(4,36): error CS0738: 'Delete' does not implement interface member 'ITaskCallback.GetAdditionalItemsToBeCopied()'. 'Delete.GetAdditionalItemsToBeCopied()' cannot implement 'ITaskCallback.GetAdditionalItemsToBeCopied()' because it does not have the matching return type of 'IEnumerable<ITaskItem>'. [/Users/builder/azdo/_work/3/s/xamarin-macios/msbuild/Xamarin.MacDev.Tasks/Xamarin.MacDev.Tasks.csproj]

@dellis1972

dellis1972 commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

🤦

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: d77386bf054c3e0f565151f2ca6acb32e53ada55 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMBOT-1105.Monterey'
Hash: d77386bf054c3e0f565151f2ca6acb32e53ada55 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: d77386bf054c3e0f565151f2ca6acb32e53ada55 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 5 tests failed, 218 tests passed.

Failures

❌ bcl tests

5 tests failed, 64 tests passed.
Details
  • [NUnit] Mono Mac OS X BCL tests group 3/Mac Full/Debug: Failed (Test run failed.
    Tests run: 11328 Passed: 10552 Inconclusive: 0 Failed: 1 Ignored: 98)
  • [NUnit] Mono Mac OS X BCL tests group 3/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 8755 Passed: 8174 Inconclusive: 0 Failed: 1 Ignored: 46)
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - simulator/Debug: Failed
  • [NUnit] Mono BCL tests group 2/tvOS - simulator/Debug: Failed
  • [NUnit] Mono CorlibTests/watchOS 32-bits - simulator/Debug: Failed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d77386bf054c3e0f565151f2ca6acb32e53ada55 [PR build]

@rolfbjarne

rolfbjarne commented Nov 17, 2022

Copy link
Copy Markdown
Member

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2629).

@rolfbjarne
rolfbjarne merged commit 3e4aa12 into dotnet:main Nov 17, 2022
@dellis1972
dellis1972 deleted the fastdelete branch November 18, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes
@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes
@emaf emaf emaf approved these changes
@mauroa mauroa Awaiting requested review from mauroa mauroa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dellis1972 @vs-mobiletools-engineering-service2 @rolfbjarne @jonathanpeppers @emaf